Export ProviderConfig from Node.js and Python SDKs#1048
Open
stephentoub wants to merge 1 commit intomainfrom
Open
Export ProviderConfig from Node.js and Python SDKs#1048stephentoub wants to merge 1 commit intomainfrom
stephentoub wants to merge 1 commit intomainfrom
Conversation
ProviderConfig was defined in both SDKs but not re-exported from their public API entry points. Consumers had to duplicate the type locally to use it for Responses API configuration (wireApi: 'responses'). - Node.js: add ProviderConfig to the type re-exports in src/index.ts - Python: import ProviderConfig in copilot/__init__.py and add to __all__ Fixes github/copilot-sdk-partners#7 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes ProviderConfig as part of the public API surface for the Node.js and Python SDKs, so consumers can reference the SDK’s canonical BYOK/Responses provider type instead of duplicating it locally.
Changes:
- Node.js: re-exported
ProviderConfigfrom the top-levelsrc/index.tstype exports. - Python: re-exported
ProviderConfigby importing it fromsessionand adding it to__all__.
Show a summary per file
| File | Description |
|---|---|
| python/copilot/init.py | Adds ProviderConfig to the package import surface and __all__ for public export. |
| nodejs/src/index.ts | Adds ProviderConfig to the top-level export type { ... } block for public type re-export. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Contributor
Cross-SDK Consistency Review ✅This PR correctly addresses a cross-SDK export gap and maintains consistency across all four SDK implementations.
No further changes needed — this PR brings all SDKs to parity.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProviderConfigis the only way to configure the Responses API (wireApi: 'responses') and BYOK providers, but it wasn't re-exported from the public API of the Node.js or Python SDKs. Consumers had to duplicate the type locally to reference it in their own code.This adds
ProviderConfigto the public exports of both SDKs:export type { ... }block insrc/index.tssessionand added to__all__incopilot/__init__.pyGo and .NET were already fine — Go exports via capitalized naming and .NET via
public class.Fixes #968