Skip to content

Removing Pr-Preview from netlify, moving to GitHub page#7595

Open
saurabhraghuvanshii wants to merge 3 commits intolayer5io:masterfrom
saurabhraghuvanshii:build
Open

Removing Pr-Preview from netlify, moving to GitHub page#7595
saurabhraghuvanshii wants to merge 3 commits intolayer5io:masterfrom
saurabhraghuvanshii:build

Conversation

@saurabhraghuvanshii
Copy link
Copy Markdown
Member

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: saurabhraghuvanshii <saurabhsraghuvanshi@gmail.com>
@arjunmehta-git
Copy link
Copy Markdown

Thanks for taking this on, @saurabhraghuvanshii. Moving PR previews from Netlify to GitHub Pages is a meaningful infrastructure change that reduces our external dependency, and the workflow changes look structurally sound.

A few things to address before merge:

  • Empty description and issue reference — The PR body is still the template placeholder and "This PR fixes #" is blank. This is a significant workflow change that deserves a clear description of what's changing, why Netlify is being removed, and what the GitHub Pages preview URL pattern will look like for contributors.
  • Preview verification — Has the new GitHub Pages preview workflow been tested end-to-end on this branch? Specifically: does a commit to this PR trigger a deploy, and does the resulting preview URL work as expected? Broken PR previews would block the entire contributor review cycle.
  • Removal of preview-site.yml — Deleting the Netlify preview workflow means the l5io bot's preview comments ("🚀 Preview for commit...") will stop appearing. Confirm the GitHub Pages workflow produces an equivalent notification so contributors know where to find the preview.
  • Signed commits — The checkbox is checked, good.

The intent is right. Please flesh out the description and confirm the new workflow is functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants