Skip to content

[diskann-garnet] Create workflow to publish to nuget#926

Open
tiagonapoli wants to merge 1 commit intomainfrom
tiagonapoli/publish-diskann-garnet-workflow
Open

[diskann-garnet] Create workflow to publish to nuget#926
tiagonapoli wants to merge 1 commit intomainfrom
tiagonapoli/publish-diskann-garnet-workflow

Conversation

@tiagonapoli
Copy link
Copy Markdown
Contributor

@tiagonapoli tiagonapoli commented Apr 8, 2026

Create Github Actions workflow to publish to Nuget using Trusted Publishing nuget feature.

  • Publishes will be triggered by diskann-garnet-v* tags

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions workflow to build the diskann-garnet native library for Linux/Windows, package it into a NuGet package (via the existing .nuspec), and publish to nuget.org using Trusted Publishing when garnet-v* tags are pushed (or optionally via manual dispatch).

Changes:

  • Introduces a new publish-diskann-garnet-nuget.yml workflow triggered by garnet-v* tags and workflow_dispatch.
  • Builds native artifacts on Ubuntu and Windows and uploads them as workflow artifacts.
  • Packs a .nupkg from diskann-garnet.nuspec and publishes to NuGet using OIDC (Trusted Publishing).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +6 to +17
on:
workflow_dispatch:
inputs:
publish:
description: "Publish package to NuGet"
required: false
type: boolean
default: false
push:
tags:
- "garnet-v*"

Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow_dispatch path can publish from any branch ref (it checks out whatever ref the dispatch is run on). For release publishing, consider restricting manual publishing to main (or to tags only) and/or using a protected environment with required reviewers so an arbitrary branch can’t publish to NuGet via OIDC.

Copilot uses AI. Check for mistakes.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.42%. Comparing base (fbddda2) to head (0ebeff5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
+ Coverage   89.40%   89.42%   +0.01%     
==========================================
  Files         449      448       -1     
  Lines       85057    84856     -201     
==========================================
- Hits        76049    75879     -170     
+ Misses       9008     8977      -31     
Flag Coverage Δ
miri 89.42% <ø> (+0.01%) ⬆️
unittests 89.26% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- name: Install Rust ${{ env.rust_stable }}
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.rust_stable }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want stable or the version in toolchain.toml?

Add GitHub Actions workflow to build diskann-garnet native libraries
on Linux and Windows, package as a NuGet package, and publish to
nuget.org.

- Multi-platform build matrix (ubuntu-latest, windows-latest)
- Rust cache via Swatinem/rust-cache@v2
- Version consistency validation (nuspec == Cargo.toml == tag)
- Publish gated on diskann-garnet-v* tag push or manual dispatch from main
- Uses NUGET_API_KEY secret for NuGet authentication

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tiagonapoli tiagonapoli force-pushed the tiagonapoli/publish-diskann-garnet-workflow branch from ff58d8a to 0ebeff5 Compare April 9, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants