fixes bug for js winml sdk where binaries were not overwritten properly#617
Open
fixes bug for js winml sdk where binaries were not overwritten properly#617
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
baijumeswani
approved these changes
Apr 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix a JS WinML SDK installation bug where previously installed native binaries could remain on disk, leading to stale/incorrect binaries being used after switching variants (e.g., standard ↔ WinML).
Changes:
- Adds a pre-install cleanup step to delete existing files in the native binary directory before extracting new binaries.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.