Python: fix(tests): split pytest.raises blocks to eliminate dead code#5171
Open
Bahtya wants to merge 1 commit intomicrosoft:mainfrom
Open
Python: fix(tests): split pytest.raises blocks to eliminate dead code#5171Bahtya wants to merge 1 commit intomicrosoft:mainfrom
Bahtya wants to merge 1 commit intomicrosoft:mainfrom
Conversation
pytest.raises exits after the first exception, so multiple statements
in a single block are dead code. Split each multi-statement
pytest.raises block into separate blocks so all error cases are
actually tested.
Also remove the dead detect_media_type_from_base64(data_str="") call
which does not raise (base64.b64decode("") is valid).
Fixes microsoft#5115
Signed-off-by: bahtya <bahtyar153@qq.com>
github-actions
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multiple
with pytest.raises(...)blocks intest_types.pycontain more than one statement. Sincepytest.raisesexits after the first exception, all subsequent statements are dead code that never execute, creating a false sense of test coverage.Fix
Split each multi-statement
pytest.raisesblock into separate blocks so all error cases are actually tested.Also removed the dead
detect_media_type_from_base64(data_str="")call from the base64 error block, asbase64.b64decode("")is valid and does not raise.Fixes #5115