feat(react-message-bar): add useMessageBarBase_unstable hook#35908
Open
dmytrokirpa wants to merge 3 commits intomicrosoft:masterfrom
Open
feat(react-message-bar): add useMessageBarBase_unstable hook#35908dmytrokirpa wants to merge 3 commits intomicrosoft:masterfrom
dmytrokirpa wants to merge 3 commits intomicrosoft:masterfrom
Conversation
Adds `useMessageBarBase_unstable` hook and `MessageBarBaseProps`/`MessageBarBaseState` types that expose the core ARIA/reflow/announce logic without design-specific `shape` prop. The styled `useMessageBar_unstable` now delegates to the base hook and sets the default intent icon (getIntentIcon). Updates `renderMessageBar_unstable` to accept `MessageBarBaseState`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 610 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 499 | Changed |
vr-tests-react-components/ProgressBar converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 119 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 128 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 23 | Changed |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useMessageBarBase_unstablehook andMessageBarBaseProps/MessageBarBaseStatetypes (DistributiveOmit<..., 'shape'>)intentstays in base as it drives accessibility behavior (politeness)useMessageBar_unstabledelegates to base hook and sets default icon children viagetIntentIcon(state.intent)renderMessageBar_unstableto acceptMessageBarBaseStateTest plan
yarn nx build react-message-bar— passes, API md updatedyarn nx lint react-message-bar— passesyarn nx test react-message-bar— 105 tests passPart of #35562
🤖 Generated with Claude Code