Skip to content

Add address_space_id parameter to futex wait/wake for multi-process support#759

Open
wdcui wants to merge 1 commit intomainfrom
wdcui/pr3i-futex-address-space
Open

Add address_space_id parameter to futex wait/wake for multi-process support#759
wdcui wants to merge 1 commit intomainfrom
wdcui/pr3i-futex-address-space

Conversation

@wdcui
Copy link
Copy Markdown
Member

@wdcui wdcui commented Apr 7, 2026

Summary

  • Add address_space_id: u64 discriminator to FutexEntry, bucket hashing, wait(), and wake() to prevent false aliasing between processes with overlapping virtual address ranges.
  • Userland callers (single address space) pass 0.
  • Update all shim callers and futex tests.

Split from #743.

…upport

Add address_space_id: u64 discriminator to FutexEntry, bucket hashing,
wait(), and wake() to prevent false aliasing between processes with
overlapping virtual address ranges. On userland (non-overlapping VA
partitions) callers pass 0. Update all shim callers and tests.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/method_parameter_count_changed.ron

Failed in:
  litebox::sync::futex::FutexManager::wait takes 4 parameters in /home/runner/work/litebox/litebox/target/semver-checks/git-main/3f147ef888356c93d58d41289364c3f400dffaec/litebox/src/sync/futex.rs:83, but now takes 5 parameters in /home/runner/work/litebox/litebox/litebox/src/sync/futex.rs:98
  litebox::sync::futex::FutexManager::wake takes 3 parameters in /home/runner/work/litebox/litebox/target/semver-checks/git-main/3f147ef888356c93d58d41289364c3f400dffaec/litebox/src/sync/futex.rs:135, but now takes 4 parameters in /home/runner/work/litebox/litebox/litebox/src/sync/futex.rs:155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant