Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s build/publishing configuration to move to Arcade “publishing v4”, which stages outputs and relies on pipeline artifacts instead of logging-command uploads (improving efficiency and compliance/scanning).
Changes:
- Add
eng/Publishing.propsto set the repo’s publishing version to 4. - Update
azure-pipelines.ymlto removeenablePublishUsingPipelines(now handled via artifact publishing configuration). - Update
azure-pipelines-official.ymlto opt into publishing v4 (publishingVersion: 4) and configure post-build to use pipeline artifacts (publishingInfraVersion: 4), plus remove the symbol-server PAT variable group and related MSBuild properties.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/Publishing.props | Introduces MSBuild property intended to declare publishing version 4. |
| azure-pipelines.yml | Removes deprecated/unused enablePublishUsingPipelines flags from job template parameters. |
| azure-pipelines-official.yml | Switches official pipeline configuration to publishing v4 and updates post-build template parameters accordingly. |
Member
|
Member
Author
|
Looks like it's been like that forever...looking into it. The other two windows legs are uploading under the same names. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V4 publishing removes the use of logging commands to upload files for publishing, instead staging outputs and then using pipeline artifacts to upload them. This is more efficient and ensures that those files go through standard scanning procedures.