[Bug Fix] Make execution subagent model exp based instead of simple.#308642
Open
vikramnitin9 wants to merge 2 commits intomainfrom
Open
[Bug Fix] Make execution subagent model exp based instead of simple.#308642vikramnitin9 wants to merge 2 commits intomainfrom
vikramnitin9 wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes execution subagent configuration so model selection is experiment-based (ensuring flights pick up the intended model), and updates the default execution subagent tool-calling limit.
Changes:
- Switch
chat.executionSubagent.modelto an experiment-based config and read it viagetExperimentBasedConfig(...). - Increase default
chat.executionSubagent.toolCallLimitfrom 5 to 10. - Mark execution subagent settings as experiment-driven in the extension configuration (
onExptag).
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/configuration/common/configurationService.ts | Makes ExecutionSubagentModel experiment-based and raises default tool-call limit to 10. |
| extensions/copilot/src/extension/prompt/node/executionSubagentToolCallingLoop.ts | Reads execution subagent model via experiment-based configuration lookup. |
| extensions/copilot/package.json | Updates defaults/tags for execution subagent settings to reflect experiment-based behavior and new limit. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execution subagent model is not set as experiment-based, which means that our flights are not using the correct models. Fixed that, and also changed the default execution subagent tool calling limit to 10.
Supercedes #308570.
@bhavyaus - tagging you for approval.