Skip to content

gh-148252: Fix stack depth calculation in binary reader on 32-bit platforms#148253

Open
pablogsal wants to merge 1 commit intopython:mainfrom
pablogsal:gh-148178-pyb-32bit-fix
Open

gh-148252: Fix stack depth calculation in binary reader on 32-bit platforms#148253
pablogsal wants to merge 1 commit intopython:mainfrom
pablogsal:gh-148178-pyb-32bit-fix

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Apr 8, 2026 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 8, 2026
Open
@pablogsal pablogsal force-pushed the gh-148178-pyb-32bit-fix branch from bd58bbb to 8d1359f Compare April 8, 2026 13:52
@pablogsal
pythongh-148252: Fix stack depth calculation in binary reader on 32-b…
cc18e91 
…it platforms

Compute ``final_depth`` in ``decode_stack_pop_push()`` and
``decode_stack_suffix()`` using ``uint64_t`` before validating it.

On 32-bit builds, using ``size_t`` arithmetic for ``keep + push`` can wrap
for large input values, causing the later bounds check to validate the wrong
final depth. Using a widened type keeps the validation aligned with the
actual result.
@pablogsal pablogsal force-pushed the gh-148178-pyb-32bit-fix branch from 8d1359f to cc18e91 Compare April 8, 2026 22:53
@pablogsal pablogsal marked this pull request as ready for review April 8, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pablogsal