Skip to content

Port to Python3 - fix regressions#22

Open
Saumya-Mishra9129 wants to merge 1 commit intosugarlabs:masterfrom
Saumya-Mishra9129:major
Open

Port to Python3 - fix regressions#22
Saumya-Mishra9129 wants to merge 1 commit intosugarlabs:masterfrom
Saumya-Mishra9129:major

Conversation

@Saumya-Mishra9129
Copy link
Copy Markdown
Member

@Saumya-Mishra9129 Saumya-Mishra9129 commented Jun 28, 2020

@quozl @pro-panda Can you help with how to test this change? I tried with command python3 logcollect.py <server address> given here

logcollect.py http://server.name/submit.php
but that didn't work. Got in some unicode errors . Is it a right way to test??

http.client.HTTP used to be present in Python 2.0 as httplib.HTTP
but It is deprecated completely in python3 and later versions

Workaround - Use http.client.HTTPConnection and its methods

Regression caused in sugarlabs@5941034
@Saumya-Mishra9129 Saumya-Mishra9129 marked this pull request as ready for review June 30, 2020 08:22
@quozl
Copy link
Copy Markdown
Contributor

quozl commented Jul 2, 2020

You would have to set up a compatible server. It should accept a POST using the content type of multipart/form-data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants